RE: [PATCH v4 02/19] blkcg: Added a app identifier support for blkcg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hannes,
Thanks for the review.

> +		ret = -EINVAL;
> +		goto out_put;
> +	}
> +	strlcpy(blkcg->fc_app_id, buf, len);

>String or UUID?
>And will it be NULL-terminated?
>Wouldn't it be better to use 'memcpy' here?
>And it is NULL terminated: what happens if the user sets a 128-byte string?
>IE shouldn't the app_id be 129 bytes long if it's assumed to be
>NULL-terminated?
[Muneendra]It is a string and it is NULL terminated.
Agreed it should be 129 bytes long.

Regards,
Muneendra.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux