Hi Hannes,
Thanks for the review.
> + { FC_PORTSTATE_LOOPBACK, "Loopback", 8 },
> + { FC_PORTSTATE_DELETED, "Deleted", 7 },
> + { FC_PORTSTATE_MARGINAL, "Marginal", 8 },
>Why did you append the length of the string here?
>This doesn't have anything to do with this patch, but rather is an
>improvement/modification of the original code, and should be delegated to a
>separate patch.
[Muneendra] fc_enum_name_match needs the string length for validation.
get_fc_port_state_match will use this as part of setting the port_state in
sysfs for validation(next patch 4/5).
> };
> fc_enum_name_search(port_state, fc_port_state, fc_port_state_names)
> +fc_enum_name_match(port_state, fc_port_state, fc_port_state_names)
> #define FC_PORTSTATE_MAX_NAMELEN 20
>
....
...
>Other than that:
>Reviewed-by: Hannes Reinecke <hare@xxxxxxx>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG
Nürnberg), Geschäftsführer: Felix Imendörffer
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
