RE: [PATCH] qla2xxx: fix RSCN handling on big-endian systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday, February 22, 2007 11:09 AM, Malahal Naineni wrote:
> I removed the cable and didn't put it back at all for more 
> than 1 hour.
> There is no recovery here.  When I disable an F-port, after 
> few seconds the remote port state is set to something other 
> than 'online'. Why not same behaviour for remote ports on 
> FL-port. With my patch, the behaviour is same whether the 
> remote port is attached to an FL-port or an F-port.
I'm sorry, I mis-understood your initial comment. The problem is
happening only with FL-port (on big-endian platform).
Let me verify it with test team in here and will get back to you.

> Well, my patch fixed the problem! qla2x00_device_resync() 
> fails to call
> qla2x00_mark_device_lost() for RSCN's affecting area or 
> domain because the following evaluates to true always due to 
> b24 field being incorrect:
> 
> 		(fcport->d_id.b24 & mask) != d_id.b24
Agree, your patch will fix it. However, my point is that: instead of
having #idfef in the header, 
1. make access to the structure member to be equal in size. 
2. or introduce macro that combins al_pa/area/domain
Those are preferred solution, in my opinion. 

Again, thank you for your findings. 
Based on your findings, let us investigate further and come up with
right answer for it.

Thank you,

Seokmann
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux