On 11/11/20 4:05 AM, Martin K. Petersen wrote:
Martin,
The current code would use the first descriptor, because it's longer
than the NAA descriptor. But this is wrong, the kernel is supposed to
prefer NAA descriptors over T10 vendor ID. Designator length should
only be used to compare designators of the same type.
This patch addresses the issue by separating designator priority and
length.
I am concerned that we're going to break existing systems since their
/dev/disk/by-* names might change as a result of this. Thoughts?
No, this shouldn't happen. With the standard udev rules we're creating
symlinks for all possible VPD designators, so they don't change.
The patch really is just for multipath to handle error cases better;
we've had this situation when reading the vpd page hit an I/O error.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
