Hello, Generally looks good to me. A few nits. On Tue, Nov 03, 2020 at 12:48:05PM +0530, Muneendra wrote: > Added a new function cgroup_get_from_kernfs_id to retrieve the cgroup > associated with cgroup id. > It takes cgroupid as an argument and returns cgrp and on failure > it returns NULL. > Exported the same as this can be used by blk-cgorup.c Can you please reflow the above paragraph? > +struct cgroup *cgroup_get_from_kernfs_id(u64 id); Let's just name it cgroup_get_from_id(). There's no other id. We can rename cgroup_path_from_kernfs_id() later. > +/* /** starts a function comment. > + * cgroup_get_from_kernfs_id : get the cgroup associated with cgroup id > + * @id: cgroup id > + * On success it returns the cgrp on failure it returns NULL > + */ With the above nits updated, please feel free to add Acked-by: Tejun Heo <tj@xxxxxxxxxx> Thanks. -- tejun
