Luo Jiaxing <luojiaxing@xxxxxxxxxx> writes: > Seq instroduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE for ^^^^^^^^^^ ^^^^^ introduce macro > Read-Write file, So we apply it at dwc3 debugfs to reduce some duplicate ^^ ^^^^^^^^^ so duplicated > code. to be fair, your commit is doing more than what it claims. Maybe update commit log with a "while at that, also use DEFINE_SHOW_ATTRIBUTE() where possible". > Signed-off-by: Luo Jiaxing <luojiaxing@xxxxxxxxxx> other than that, this looks okay. Since it depends on the definition of DEFINE_SHOW_STORE_ATTRIBUTE: Acked-by: Felipe Balbi <balbi@xxxxxxxxxx> -- balbi
Attachment:
signature.asc
Description: PGP signature