Re: [PATCH 1/4] pm80xx: make mpi_build_cmd locking consistent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Viswas,

Your patch descriptions need some work. See

     Documentation/process/submitting-patches.rst

Specifically the section named "Describe your changes".

> the missing task completions appear to be

Which missing completions are these?

[...]

> if a sata request issues from cpu zero when a management request
> issues, then there is some 'tearing' and the issue queue is sort of
> broken and we lose track of issues.

Too vague for a problem description.

> disabling interrupts may be overkill because there may not be cases
> where we're using this from interrupt context (the interrupt path
> has a different per-queue lock).

No clear description of what the fix is.

Please reword your patch descriptions so it is clear to the reviewer
what the problem is and how it is being addressed in the code changes
that follow.

Thank you!

-- 
Martin K. Petersen	Oracle Linux Engineering



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux