Sorry for the annoyance, i split it, since these patches address different issues: the nosync patch just (re)allows an appropriate commandline setting (with or without the wd33c93 patches applied) to cope with some uncooperative devices, while the other one depends on the 2nd wd33c93 patch being applied already/simultaneously. kind regards peter On Fri, 16 Feb 2007, James Bottomley wrote: > Date: Fri, 16 Feb 2007 09:36:02 -0600 > From: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> > To: post@xxxxxxxx > Cc: linux-scsi@xxxxxxxxxxxxxxx, Ralf Baechle <ralf@xxxxxxxxxxxxxx>, > Kumba <kumba@xxxxxxxxxx>, Thiemo Seufer <ths@xxxxxxxxxxxx>, > Tim Yamin <plasmaroo@xxxxxxxxxx> > Subject: Re: [PATCH][SCSI] sgiwd93.c: interfacing to wd33c93 > > On Mon, 2007-02-12 at 15:27 +0100, peter fuerst wrote: > > ======================================================================== > > --- dc7bdc97927ea1c519f0d8bd3133739600c841d4/drivers/scsi/sgiwd93.c Sat Oct 7 00:00:00 2006 > > +++ new/drivers/scsi/sgiwd93.c Sun Feb 11 22:10:06 2007 > > @@ -250,3 +250,3 @@ > > > > - hdata->wh.no_sync = 0; > > + if (0xff == hdata->wh.no_sync) hdata->wh.no_sync = 0; > > > > ======================================================================== > > > > > > ======================================================================== > > --- dc7bdc97927ea1c519f0d8bd3133739600c841d4/drivers/scsi/sgiwd93.c Sat Oct 7 00:00:00 2006 > > +++ stage2/drivers/scsi/sgiwd93.c Sun Feb 11 22:10:06 2007 > > @@ -248,3 +248,3 @@ > > > > - wd33c93_init(host, regs, dma_setup, dma_stop, WD33C93_FS_16_20); > > + wd33c93_init(host, regs, dma_setup, dma_stop, WD33C93_FS_MHZ(20)); > > > > ======================================================================== > > You don't make it easy, do you ... these are two separate patches for > overlapping regions of the file ... neither quilt nor git likes this way > of doing things. Plus the if should be > > if (hdata->wh.no_sync == 0xff) > hdata->wh.no_sync = 0; > > to match the style of the sgiwd93.c. > > Since this is pretty simple, I fixed it up. > > James > > > > - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
