> On Oct 20, 2020, at 2:19 AM, Javed Hasan <jhasan@xxxxxxxxxxx> wrote: > > <JH> In libfc we do have logic to split FCP commands but not for CT commands. > If I am adding all attributes of RHBA then total length is going upto 2750(approx), > Which is far more than 2048 and that is causing problem. > Practically all version/names get covered with in 100 bytes. following length fields that are being added by this patch will never exceed 64 bytes IIRC. +#define FC_FDMI_HBA_ATTR_MODEL_LEN 100 +#define FC_FDMI_HBA_ATTR_MODELDESCR_LEN 100 +#define FC_FDMI_HBA_ATTR_HARDWAREVERSION_LEN 100 +#define FC_FDMI_HBA_ATTR_DRIVERVERSION_LEN 100 +#define FC_FDMI_HBA_ATTR_OPTIONROMVERSION_LEN 100 +#define FC_FDMI_HBA_ATTR_FIRMWAREVERSIO_LEN 100 OSNAME will need 128 bytes +#define FC_FDMI_HBA_ATTR_OSNAMEVERSION_LEN 100 I would like to see more realistic numbers for these length than just arbitrary 100 bytes. -- Himanshu Madhani Oracle Linux Engineering
