Hello Himanshu, Please find my response inline. -----Original Message----- From: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx> Sent: Monday, October 19, 2020 9:35 PM To: Javed Hasan <jhasan@xxxxxxxxxxx> Cc: Martin K . Petersen <martin.petersen@xxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx; GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@xxxxxxxxxxx> Subject: [EXT] Re: [PATCH 4/4] scsi:qedf: Added attributes for RHBA and RPA External Email ---------------------------------------------------------------------- > On Oct 9, 2020, at 4:36 AM, Javed Hasan <jhasan@xxxxxxxxxxx> wrote: > > Add attributes for RHBA and RPA. > > Signed-off-by: Javed Hasan <jhasan@xxxxxxxxxxx> > --- > drivers/scsi/qedf/qedf_main.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/scsi/qedf/qedf_main.c > b/drivers/scsi/qedf/qedf_main.c index 46d185cb9ea8..e4d800cf9db7 > 100644 > --- a/drivers/scsi/qedf/qedf_main.c > +++ b/drivers/scsi/qedf/qedf_main.c > @@ -1715,6 +1715,17 @@ static void qedf_setup_fdmi(struct qedf_ctx *qedf) > FW_MAJOR_VERSION, FW_MINOR_VERSION, FW_REVISION_VERSION, > FW_ENGINEERING_VERSION); > > + snprintf(fc_host_vendor_identifier(lport->host), > + FC_VENDOR_IDENTIFIER, "%s", "Marvell"); > + > + fc_host_num_discovered_ports(lport->host) = DISCOVERED_PORTS; > + fc_host_port_state(lport->host) = FC_PORTSTATE_ONLINE; > + fc_host_max_ct_payload(lport->host) = MAX_CT_PAYLOAD; > + fc_host_num_ports(lport->host) = NUMBER_OF_PORTS; > + fc_host_bootbios_state(lport->host) = 0X00000000; > + snprintf(fc_host_bootbios_version(lport->host), > + FC_SYMBOLIC_NAME_SIZE, "%s", "Unknown"); > + > } Above changes seems like adding port attribute to transport. Did not quite get the RHBA/RPA addition here? Am I missing something? <JH> Yes, you are right. Will move the attributes (not specific to manufacturer) to libfc. > > static int qedf_lport_setup(struct qedf_ctx *qedf) > -- > 2.18.2 > -- Himanshu Madhani Oracle Linux Engineering
