On Mon, Oct 12, 2020 at 03:51:23PM -0700, James Smart wrote:
> +bool
> +sli_fw_ready(struct sli4 *sli4)
> +{
Why is this and the following function returning a bool? I ask because
the rest of the code uses EFC_FAIL/EFC_SUCCESS. The bool and the EFC_
are defined opposite in their meaning thus we have inconsistent code
patterns:
if (sli_fw_ready(sli4))
return true;
vs:
if (sli_request_features(sli4, &sli4->features, true))
return EFC_FAIL;
The rest looks good.
Reviewed-by: Daniel Wagner <dwagner@xxxxxxx>
