Re: [PATCH v4 05/31] elx: libefc_sli: Populate and post different WQEs

[Daniel Wagner <dwagner@xxxxxxx>]

On Mon, Oct 12, 2020 at 03:51:21PM -0700, James Smart wrote:
> This patch continues the libefc_sli SLI-4 library population.
> 
> This patch adds service routines to create different WQEs and adds
> APIs to issue iread, iwrite, treceive, tsend and other work queue
> entries.
> 
> Co-developed-by: Ram Vegesna <ram.vegesna@xxxxxxxxxxxx>
> Signed-off-by: Ram Vegesna <ram.vegesna@xxxxxxxxxxxx>
> Signed-off-by: James Smart <james.smart@xxxxxxxxxxxx>

Looks goods to me.

Reviewed-by: Daniel Wagner <dwagner@xxxxxxx>




> +	case SLI4_CQE_CODE_RELEASE_WQE: {
> +		struct sli4_fc_wqec *wqec = (void *)cqe;
> +
> +		*etype = SLI4_QENTRY_WQ_RELEASE;
> +		*r_id = le16_to_cpu(wqec->wq_id);
> +		rc = EFC_SUCCESS;
> +		break;
> +	}

Nitpick, the rest of the cases do

	case XXX :
	{
		[...]
	}