On Mon, Oct 12, 2020 at 03:51:17PM -0700, James Smart wrote: > +#define SLI4_BMBX_WRITE_HI(r) \ > + ((upper_32_bits(r) & ~SLI4_BMBX_MASK_HI) | SLI4_BMBX_HI) > +#define SLI4_BMBX_WRITE_LO(r) \ > + (((upper_32_bits(r) & SLI4_BMBX_MASK_HI) << 30) | \ > + (((r) & ~SLI4_BMBX_MASK_LO) >> 2)) These could also be inline function. This would align it with the rest of the file. The rest looks good. Reviewed-by: Daniel Wagner <dwagner@xxxxxxx>
