On 10/19/2020 8:21 AM, Hannes Reinecke wrote:
On 10/13/20 12:51 AM, James Smart wrote:+ +#define EFC_SUCCESS 0 +#define EFC_FAIL 1 +You said you were going to kill this ...
No - we said we would standardize on defines and not put explicit 0's or 1s in the code.
[ .. ]+ SLI4_LNK_ATTN_TYPE_NO_HARD_ALPA = 0x03, + + SLI4_LNK_ATTN_P2P = 0x01, + SLI4_LNK_ATTN_FC_AL = 0x02, + SLI4_LNK_ATTN_INTERNAL_LOOPBACK = 0x03, + SLI4_LNK_ATTN_SERDES_LOOPBACK = 0x04, + + SLI4_LNK_ATTN_1G = 0x01, + SLI4_LNK_ATTN_2G = 0x02, + SLI4_LNK_ATTN_4G = 0x04, + SLI4_LNK_ATTN_8G = 0x08, + SLI4_LNK_ATTN_10G = 0x0a, + SLI4_LNK_ATTN_16G = 0x10, +}; +Ah. 16G Only?
yeah - this is a miss. We added the 32G, 64G, and 128G in the link up reporting, but forgot this structure. Will fix that.
+/* Prameters used to populate WQE*/Parameters ...
yep. -- james
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature