Hi Tejun, Thanks for the input. >> + cgrp = cgroup_get_from_kernfs_id(id); >> + if (!cgrp) >> + return -ENOENT; >> + > >+ css = cgroup_get_e_css(cgrp, &io_cgrp_subsys); >> + if (!css) >> + return -ENOENT; >> + >> + blkcg = css_to_blkcg(css); >> + if (!blkcg) >> + return -ENOENT; > >+ return -EINVAL; > >+ strlcpy(blkcg->app_id, buf, len); >Shouldn't the cgrp and css be put before exit? [Muneendra]Correct me if iam wrong. You mean to add cgroup_put(cgrp) and css_put(css) before exit ? > + > > struct list_head all_blkcgs_node; > + char app_id[APPID_LEN]; >Please use a more specific name and gate them behind a CONFIG. [Muneendra] Agree will do the changes. Regards, Muneendra. Thanks. -- tejun
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
