Hi all, sparked off by a recent discussion here is a patchset to update the printk() usage in bfa. All 'legacy' printk() calls are moved to structured logging (ie dev_printk() and friends), and the code is restructured to move the debugging code over to that, too. As usual, comments and reviews are welcome. Hannes Reinecke (4): bfa: Remove legacy printk() usage bfa: drop unused 'bfad' and 'pcidev' arguments bfa: remove bfa_pcidev_s bfa: move bfa_sm_fault() to dev_err() drivers/scsi/bfa/bfa.h | 8 +--- drivers/scsi/bfa/bfa_core.c | 51 +++++++++++-------------- drivers/scsi/bfa/bfa_cs.h | 2 +- drivers/scsi/bfa/bfa_fcpim.c | 8 ++-- drivers/scsi/bfa/bfa_ioc.c | 68 +++++++++++++++++----------------- drivers/scsi/bfa/bfa_ioc.h | 23 +++--------- drivers/scsi/bfa/bfa_ioc_ct.c | 8 ++-- drivers/scsi/bfa/bfa_modules.h | 28 +++++--------- drivers/scsi/bfa/bfa_svc.c | 31 ++++++---------- drivers/scsi/bfa/bfad.c | 82 +++++++++++++++++------------------------ drivers/scsi/bfa/bfad_bsg.c | 12 ++---- drivers/scsi/bfa/bfad_debugfs.c | 32 ++++++---------- drivers/scsi/bfa/bfad_drv.h | 4 +- drivers/scsi/bfa/bfad_im.c | 14 +++---- 14 files changed, 150 insertions(+), 221 deletions(-) -- 2.16.4