On 10/15/20 12:57 PM, Douglas Gilbert wrote: > sgl_alloc_order() can fail when 'length' is large on a memory > constrained system. When order > 0 it will potentially be > making several multi-page allocations with the later ones more > likely to fail than the earlier one. So it is important that > sgl_alloc_order() frees up any pages it has obtained before > returning NULL. In the case when order > 0 it calls the wrong > free page function and leaks. In testing the leak was > sufficient to bring down my 8 GiB laptop with OOM. I've picked this one up, thanks. -- Jens Axboe