Hi Muneendra, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on scsi/for-next] [also build test WARNING on mkp-scsi/for-next next-20201015] [cannot apply to v5.9] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Muneendra/scsi-Support-to-handle-Intermittent-errors/20201015-182315 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/6bb032ada0c283207bbbf0d17a5d8091f49ebb03 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Muneendra/scsi-Support-to-handle-Intermittent-errors/20201015-182315 git checkout 6bb032ada0c283207bbbf0d17a5d8091f49ebb03 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): In file included from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/module.h:12, from drivers/scsi/scsi_transport_fc.c:11: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ drivers/scsi/scsi_transport_fc.c: In function 'fc_rport_set_marginal_state': >> drivers/scsi/scsi_transport_fc.c:982:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 982 | int ret = 0; | ^~~ vim +/ret +982 drivers/scsi/scsi_transport_fc.c 969 970 /* 971 * Sets port_state to Marginal/Online. 972 * On Marginal it Sets no retries on abort in scmd->state for all 973 * outstanding io of all the scsi_devs 974 * This only allows ONLINE->MARGINAL and MARGINAL->ONLINE 975 */ 976 static ssize_t fc_rport_set_marginal_state(struct device *dev, 977 struct device_attribute *attr, 978 const char *buf, size_t count) 979 { 980 struct fc_rport *rport = transport_class_to_rport(dev); 981 enum fc_port_state port_state; > 982 int ret = 0; 983 984 ret = get_fc_port_state_match(buf, &port_state); 985 986 if (port_state == FC_PORTSTATE_MARGINAL) { 987 /* 988 * Change the state to marginal only if the 989 * current rport state is Online 990 * Allow only Online->marginal 991 */ 992 if (rport->port_state == FC_PORTSTATE_ONLINE) { 993 rport->port_state = port_state; 994 scsi_target_chg_noretries_abort(&rport->dev, 1); 995 } 996 } else if (port_state == FC_PORTSTATE_ONLINE) { 997 /* 998 * Change the state to Online only if the 999 * current rport state is Marginal 1000 * Allow only MArginal->Online 1001 */ 1002 if (rport->port_state == FC_PORTSTATE_MARGINAL) { 1003 rport->port_state = port_state; 1004 scsi_target_chg_noretries_abort(&rport->dev, 0); 1005 } 1006 } else 1007 return -EINVAL; 1008 return count; 1009 } 1010 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
