Yes I can make it boolean. Will change it in a future patch submission. Thanks, Sumant -----Original Message----- From: Richard Knutsson [mailto:ricknu-0@xxxxxxxxxxxxxx] Sent: Thursday, February 15, 2007 12:10 AM To: Patro, Sumant Cc: James.Bottomley@xxxxxxxxxxxx; akpm@xxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Kolli, Neela; Yang, Bo; Patro, Sumant Subject: Re: [PATCH 3/6] scsi: megaraid_sas - throttle io if FW is busy Sumant Patro wrote: > Checks added in megasas_queue_command to know if FW is able to process > commands within the timeout period. If number of retries is 2 or more, > the driver stops sending cmd to FW. IO is resumed when pending cmd > count reduces to 16 or 10 seconds has elapsed from the time cmds were > last sent to FW. > > Signed-off-by: Sumant Patro <sumant.patro@xxxxxxx> > --- > > drivers/scsi/megaraid/megaraid_sas.c | 27 +++++++++++++++++++++++++ > drivers/scsi/megaraid/megaraid_sas.h | 3 ++ > 2 files changed, 30 insertions(+) > > [snip] > diff -uprN linux-feb13-new-p2/drivers/scsi/megaraid/megaraid_sas.h linux-feb13-new-p3/drivers/scsi/megaraid/megaraid_sas.h > --- linux-feb13-new-p2/drivers/scsi/megaraid/megaraid_sas.h 2007-02-13 07:22:40.000000000 -0800 > +++ linux-feb13-new-p3/drivers/scsi/megaraid/megaraid_sas.h 2007-02-13 11:37:09.000000000 -0800 > @@ -1102,6 +1102,9 @@ struct megasas_instance { > atomic_t fw_outstanding; > u32 hw_crit_error; > > + u8 is_busy; > Why not "bool is_busy:8;"? It obviously is a boolean. I would also think false/true would be more descriptive then 0/1. Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
