On Tue, 29 Sep 2020 09:38:02 +0200, Daniel Wagner wrote: > qla2xx_process_get_sp_from_handle() will clear the slot which the > current srb is stored. So this function has a side effect. Therefore, > we can't use it in qla24xx_process_mbx_iocb_response() to check > for consistency and later again in qla24xx_mbx_iocb_entry(). > > Let's move the consistency check directly into > qla24xx_mbx_iocb_entry() and avoid the double call or any open coding > of the qla2xx_process_get_sp_from_handle() functionality. Applied to 5.10/scsi-queue, thanks! [1/1] scsi: qla2xxx: Do not consume srb greedily https://git.kernel.org/mkp/scsi/c/657ed8a8a61b -- Martin K. Petersen Oracle Linux Engineering