On 2020-10-06 10:06 p.m., Martin K. Petersen wrote:
Viswas,
Changes from v1:
- Improved commit messages.
- Fixed compiler warning for
"Increase the number of outstanding IO supported" patch
Applied to 5.10/scsi-staging.
In the future please run checkpatch and make sure that the commit
messages are using imperative mood (see
Documentation/process/submitting-patches.rst, section 2).
Get thee to a nunnery! [W. Shakespeare; translation: "fuck off"]
Now that is imperative.
As for "imperative mood", I believe there is no such thing in English
grammar. My mother taught grammar and I studied French and Latin at
school. Markus Elfring objected to my:
[PATCH] lib/scatterlist: Fix memory leak in sgl_alloc_order() ***
with the same "imperative mood" line. In English, including British
(i.e. "international") English taught in south Asia, that is the
_imperative_ . Basically if you can stick "You" in front of the
verb at the start of the sentence and the sense is the same, then
it is the imperative.
Is the "imperative mood" something in Danish or German grammar?
Doug Gilbert
*** That patch was ack-ed by Bart (the culprit) and as far as I
know hasn't gone any further. My sgl-to-sgl copy, compare
and sgl_memset await that bug being sorted.