On Tue, Sep 29, 2020 at 09:38:02AM +0200, Daniel Wagner wrote: > qla2xx_process_get_sp_from_handle() will clear the slot which the > current srb is stored. So this function has a side effect. Therefore, > we can't use it in qla24xx_process_mbx_iocb_response() to check > for consistency and later again in qla24xx_mbx_iocb_entry(). > > Let's move the consistency check directly into > qla24xx_mbx_iocb_entry() and avoid the double call or any open coding > of the qla2xx_process_get_sp_from_handle() functionality. > > Fixes: 31a3271ff11b ("scsi: qla2xxx: Handle incorrect entry_type entries") > Signed-off-by: Daniel Wagner <dwagner@xxxxxxx> > --- > Hi, > > Brown bag for me please. My test patch had an open coded version of > qla2xx_process_get_sp_from_handle() which didn't consume the srb. When > I prepared it for sending it out, I 'cleaned' it up by using > qla2xx_process_get_sp_from_handle() twice. Ping.