On 10/2/20 2:33 AM, Maurizio Lombardi wrote:
> This reverts commit b0055acaedf56a2717a6e2a4b700f1959a1b60df.
>
> This warning is duplicated because the very same condition
> is already checked in __iscsit_free_cmd().
>
> Signed-off-by: Maurizio Lombardi <mlombard@xxxxxxxxxx>
> ---
> drivers/target/iscsi/iscsi_target_util.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/target/iscsi/iscsi_target_util.c b/drivers/target/iscsi/iscsi_target_util.c
> index 45ba07c6ec27..ff7830ddbd7b 100644
> --- a/drivers/target/iscsi/iscsi_target_util.c
> +++ b/drivers/target/iscsi/iscsi_target_util.c
> @@ -764,8 +764,6 @@ void iscsit_free_cmd(struct iscsi_cmd *cmd, bool shutdown)
> struct se_cmd *se_cmd = cmd->se_cmd.se_tfo ? &cmd->se_cmd : NULL;
> int rc;
>
> - WARN_ON(!list_empty(&cmd->i_conn_node));
> -
> __iscsit_free_cmd(cmd, shutdown);
> if (se_cmd) {
> rc = transport_generic_free_cmd(se_cmd, shutdown);
>
Maurizio, are you hitting these WARN()s?
Patch looks ok.
Reviewed-by: Mike Christie <michael.christie@xxxxxxxxxx>
