> On Sep 29, 2020, at 9:25 PM, Ye Bin <yebin10@xxxxxxxxxx> wrote: > > Fix follow warning: > [drivers/scsi/qla2xxx/qla_dbg.c:2451]: (warning) %ld in format string (no. 4) > requires 'long' but the argument type is 'unsigned long'. > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Signed-off-by: Ye Bin <yebin10@xxxxxxxxxx> > --- > drivers/scsi/qla2xxx/qla_dbg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c > index 1434789c9919..bb7431912d41 100644 > --- a/drivers/scsi/qla2xxx/qla_dbg.c > +++ b/drivers/scsi/qla2xxx/qla_dbg.c > @@ -2448,7 +2448,7 @@ static void ql_dbg_prefix(char *pbuf, int pbuf_size, > const struct pci_dev *pdev = vha->hw->pdev; > > /* <module-name> [<dev-name>]-<msg-id>:<host>: */ > - snprintf(pbuf, pbuf_size, "%s [%s]-%04x:%ld: ", QL_MSGHDR, > + snprintf(pbuf, pbuf_size, "%s [%s]-%04x:%lu: ", QL_MSGHDR, > dev_name(&(pdev->dev)), msg_id, vha->host_no); > } else { > /* <module-name> [<dev-name>]-<msg-id>: : */ > -- > 2.25.4 > Looks good. Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx> -- Himanshu Madhani Oracle Linux Engineering