On 9/30/20 9:52 PM, Bart Van Assche wrote:
> On 2020-09-29 10:01, Mike Christie wrote:
>> +static bool scsi_cmd_retry_allowed(struct scsi_cmnd *cmd)
>> +{
>> + if (cmd->allowed == SCSI_CMD_RETRIES_NO_LIMIT)
>> + return true;
>> +
>> + return (++cmd->retries <= cmd->allowed);
>> +}
>
> Did checkpatch complain about the parentheses in the above return statement?
>
Ah sorry. It does not.
I dropped it like I mentioned in the 0/2 patch. It looks like when I re-edited my comments I accidentally used the first version of the patch and it snuck back in.
I'll resend. It's better to get it right now instead of wasting time having someone send a cleanup patch later.
> Anyway:
>
> Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>
>
