Re: [EXT] Re: [PATCH 1/2] scsi: fc: Update statistics for host and rport on FPIN reception.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



    I'm saying that we have no idea who the "detecting" port was in all of 
    the statistics. At least, by not counting the detecting port, we know 
    that anything that has counters incrementing was generating the issue.   
    I don't know how important it is to know the detecting port - if 
    switch/fabric, it probably doesn't matter. If an NxPort, it may be 
    interesting to know.  We also have no idea if all the counter updates 
    occurred in 1 fpin, or in N fpins.    What I was suggesting was to log 
    something like "FPIN  <type> <detecting> <attached>", with one per 
    descriptor type in the FPIN.  We could default this logging off, and 
    change a tunable to turn it on.

    However, I feel like I'm trying to hard for this - so let's just ignore 
    it. We can always add it in the future.

Shyam; Got it. That makes sense.
I'll make a note of that and send out a patch for this separately.
    >
    > All the other comments make sense to me. I'll roll them in and send out another patchset shortly.
    >
    > Regards
    > Shyam
    >
    >
    Sounds good.  Thanks

    -- james






[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux