> > > Add host reset mechanism to try to recover host-side errors > during recovery flow. > > Signed-off-by: Stanley Chu <stanley.chu@xxxxxxxxxxxx> Reviewed-by Avri Altman <avri.altman@xxxxxxx> See some nit below as well. Thanks, Avri > +static void ufs_mtk_init_reset_control(struct ufs_hba *hba, > + struct reset_control **rc, > + char *str) > +{ > + *rc = devm_reset_control_get(hba->dev, str); > + if (IS_ERR(*rc)) { How about verifying that the line is not shared as well? Although this might not be an issue on your current platforms, it might save you aggravation in the future.. > + dev_info(hba->dev, "Failed to get reset control %s: %d\n", > + str, PTR_ERR(*rc)); > + *rc = NULL; > + } > +}