From: Lee Duncan <lduncan@xxxxxxxx> A customer that uses iSCSI NOPs extensively found a race condition caused in part by the two-lock system used in iscsi (a forward and a back lock), since sending an iSCSI NOP uses the forward lock, and receiving one uses the back lock. Because of this, processing of the "send" can still be in progress when the "receive" occurs, on a sufficiently fast multicore system. To handle this case, we add a new state to the "ping_task" pointer besides unassigned and assigned, called "invalid", which means the "not yet completed sending". Tests show this closes this race condition hole. Changes since V1: - Removed two redundant lines in iscsi_send_nopout() - Updated commit text to be more clear - Added this cover letter with even more info Lee Duncan (1): scsi: libiscsi: fix NOP race condition drivers/scsi/libiscsi.c | 13 ++++++++++--- include/scsi/libiscsi.h | 3 +++ 2 files changed, 13 insertions(+), 3 deletions(-) -- 2.26.2
