On Thu, 24 Sep 2020, 1:59am, Dan Carpenter wrote:
> ----------------------------------------------------------------------
> Hello Arun Easi,
>
> The patch 1e98fb0f9208: "scsi: qla2xxx: Setup debugfs entries for
> remote ports" from Sep 3, 2020, leads to the following static checker
> warning:
>
> drivers/scsi/qla2xxx/qla_dfs.c:119 qla2x00_dfs_create_rport()
> warn: 'fp->dfs_rport_dir' is an error pointer or valid
>
> drivers/scsi/qla2xxx/qla_dfs.c
> 106 qla2x00_dfs_create_rport(scsi_qla_host_t *vha, struct fc_port *fp)
> 107 {
> 108 char wwn[32];
> 109
> 110 #define QLA_CREATE_RPORT_FIELD_ATTR(_attr) \
> 111 debugfs_create_file(#_attr, 0400, fp->dfs_rport_dir, \
> 112 fp, &qla_dfs_rport_field_##_attr##_fops)
> 113
> 114 if (!vha->dfs_rport_root || fp->dfs_rport_dir)
> 115 return;
> 116
> 117 sprintf(wwn, "pn-%016llx", wwn_to_u64(fp->port_name));
> 118 fp->dfs_rport_dir = debugfs_create_dir(wwn, vha->dfs_rport_root);
> 119 if (!fp->dfs_rport_dir)
>
> Just delete this test. Debugfs functions are not supposed to be checked
> in the normal case.
Thanks Dan for reporting. I will make the change and post a separate
patch.
Regards,
-Arun
