Martin, We do not anticipate further changes to this patch or v3 series. Thanks, Nilesh > -----Original Message----- > From: Quinn Tran <qutran@xxxxxxxxxxx> > Sent: Thursday, September 17, 2020 10:23 PM > To: Bart Van Assche <bvanassche@xxxxxxx>; Nilesh Javali > <njavali@xxxxxxxxxxx>; martin.petersen@xxxxxxxxxx > Cc: linux-scsi@xxxxxxxxxxxxxxx; GR-QLogic-Storage-Upstream <GR-QLogic- > Storage-Upstream@xxxxxxxxxxx> > Subject: RE: [PATCH v3 11/13] qla2xxx: Add IOCB resource tracking > > > On 2020-09-03 21:51, Nilesh Javali wrote: > > This patch tracks number of IOCB resources used in the IO fast path. > > If the number of used IOCBs reach a high water limit, driver would > > return the IO as busy and let upper layer retry. This prevents over > > subscription of IOCB resources where any future error recovery command > > is unable to cut through. > > Enable IOCB throttling by default. > > Please use the block layer reserved tag mechanism instead of adding a > mechanism that is (a) racy and (b) triggers cache line ping-pong. > > QT: The Block layer reserve tag does fit resource we're tracking. The reserve > tag is per command. The IOCB resource is adapter specific behind all > commands. > > QT: I mean " The Block layer reserve tag does NOT fit the resource we're > tracking" >