Dne 14. 09. 20 v 4:32 Jing Xiangfeng napsal(a):
> The variable ret has been initialized with a value '0'. The assignment
> in switch-case is redundant. So remove it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@xxxxxxxxxx>
> ---
> drivers/target/iscsi/iscsi_target.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
> index cd045dc75a58..f5272ac18b16 100644
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -4516,7 +4516,6 @@ int iscsit_logout_post_handler(
> iscsit_logout_post_handler_closesession(conn);
> break;
> }
> - ret = 0;
> break;
> case ISCSI_LOGOUT_REASON_CLOSE_CONNECTION:
> if (conn->cid == cmd->logout_cid) {
> @@ -4527,7 +4526,6 @@ int iscsit_logout_post_handler(
> iscsit_logout_post_handler_samecid(conn);
> break;
> }
> - ret = 0;
> } else {
> switch (cmd->logout_response) {
> case ISCSI_LOGOUT_SUCCESS:
>
Looks ok to me.
Reviewed-by: Maurizio Lombardi <mlombard@xxxxxxxxxx>
