> On Sep 11, 2020, at 4:10 AM, Jason Yan <yanaijie@xxxxxxxxxx> wrote: > > This addresses the following coccinelle warning: > > drivers/scsi/qla2xxx/qla_init.c:7112:5-9: Unneeded variable: "rval". > Return "QLA_SUCCESS" on line 7115 > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx> > --- > drivers/scsi/qla2xxx/qla_init.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c > index 0bd04a62af83..df56ac8c3f00 100644 > --- a/drivers/scsi/qla2xxx/qla_init.c > +++ b/drivers/scsi/qla2xxx/qla_init.c > @@ -7109,10 +7109,9 @@ qla24xx_reset_adapter(scsi_qla_host_t *vha) > unsigned long flags = 0; > struct qla_hw_data *ha = vha->hw; > struct device_reg_24xx __iomem *reg = &ha->iobase->isp24; > - int rval = QLA_SUCCESS; > > if (IS_P3P_TYPE(ha)) > - return rval; > + return QLA_SUCCESS; > > vha->flags.online = 0; > ha->isp_ops->disable_intrs(ha); > @@ -7127,7 +7126,7 @@ qla24xx_reset_adapter(scsi_qla_host_t *vha) > if (IS_NOPOLLING_TYPE(ha)) > ha->isp_ops->enable_intrs(ha); > > - return rval; > + return QLA_SUCCESS; > } > > /* On sparc systems, obtain port and node WWN from firmware > -- > 2.25.4 > Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx> -- Himanshu Madhani Oracle Linux Engineering
