On Wed, 7 Feb 2007, Oliver Neukum wrote: > Am Mittwoch, 7. Februar 2007 16:05 schrieb Christoph Hellwig: > > On Wed, Feb 07, 2007 at 03:22:39PM +0100, Oliver Neukum wrote: > > > Hi, > > > > > > there's a USB mass storage device which exists in two version. One > > > reports the correct size and the other does not. Apart from that they > > > are identical and cannot be told apart. Here's a heuristic based on the > > > empirical finding that drives have even sizes. I know it's ugly, but it fixes > > > an ugly bug. > > > > Do we really need a second flag? Alternatively fix_capacity could be > > changed to mean fix size if odd. > > Until we learn about devices which really do have an odd number of sectors. > And then we'll have a problem. I'd like to avoid heuristics when we know > for sure. In fact there are devices which have an odd number of sectors. I once thought that would be a good heuristic to apply to all devices, but it won't work. Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
