Darrick J. Wong wrote:
This patch requires "libsas: Add a sysfs knob to enable/disable a phy" to be applied. It hooks the SControl write function to provide basic SATA phy control for phy enable/disable and speed limits. Power management is still broken, though it is unclear that libata actually uses those SControl bits anyway.
I don't really think exporting SControl as-is a good idea. Not all devices would act as expected if you change speed limit in SControl on the fly. Also, SATA phy speed is managed by libata core layer and used during EH. Please take a look at sata_down_spd_limit() and its usage.
-- tejun - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
