From: Jiri Kosina <jkosina@xxxxxxx>
drivers/scsi/BusLogic.c::BusLogic_Command() contains local_irq_disable() call
after local_irq_save(). This looks redundant.
Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>
Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/scsi/BusLogic.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff -puN drivers/scsi/BusLogic.c~scsi-buslogic-local_irq_disable-is-redundant-after-local_irq_save drivers/scsi/BusLogic.c
--- a/drivers/scsi/BusLogic.c~scsi-buslogic-local_irq_disable-is-redundant-after-local_irq_save
+++ a/drivers/scsi/BusLogic.c
@@ -362,10 +362,8 @@ static int BusLogic_Command(struct BusLo
interrupt could occur if the IRQ Channel was previously enabled by another
BusLogic Host Adapter or another driver sharing the same IRQ Channel.
*/
- if (!HostAdapter->IRQ_ChannelAcquired) {
+ if (!HostAdapter->IRQ_ChannelAcquired)
local_irq_save(ProcessorFlags);
- local_irq_disable();
- }
/*
Wait for the Host Adapter Ready bit to be set and the Command/Parameter
Register Busy bit to be reset in the Status Register.
_
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
