Re: [PATCH RFC 0/6] Fix a deadlock in the SCSI power management code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 31.08.20 04:53, Bart Van Assche wrote:
> Recently Martin Kepplinger reported a problem with the SCSI runtime PM
> code. Alan Stern root-caused the reported deadlock. This patch series is
> an attempt to fix that deadlock. These patches compile but have not yet
> been tested.
> 
> Bart Van Assche (6):
>   ide: Do not set the RQF_PREEMPT flag for sense requests
>   scsi: Remove an incorrect comment
>   scsi: Pass a request queue pointer to __scsi_execute()
>   scsi_transport_spi: Make spi_execute() accept a request queue pointer
>   scsi_transport_spi: Freeze request queues instead of quiescing
>   block, scsi, ide: Only submit power management requests in state
>     RPM_SUSPENDED
> 

this patchset works for me (as an alternative to Alan's initial fix:
https://lore.kernel.org/linux-scsi/20200623111018.31954-1-martin.kepplinger@xxxxxxx/T/#ma566fe2e39cb3fcccdd245564913d17a343e1d1a
)

On top of this I have to apply scsi "fixes" of course and now run
exactly this:
https://lore.kernel.org/linux-scsi/20200824190400.12339-1-martin.kepplinger@xxxxxxx/T/#u

Is this fully applicable still now? Again, the cardreader works and
suspends as expected. So thanks a lot for working on this!

Sure someone who has experience with block and scsi code should review
this, but definitely:

Tested-by: Martin Kepplinger <martin.kepplinger@xxxxxxx>




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux