On Fri, Aug 21, 2020 at 7:57 AM Martin K. Petersen <martin.petersen@xxxxxxxxxx> wrote: > > > Sreekanth, > > > This patch will add support for Non-secure Aero & Sea adapters' PCI > > IDs. > > That wording is misleading since you're effectively removing support for > these controllers. Actually we want the driver to claim the non-secure (i.e. invalid & tempered) Aero & Sea devices and print the error message to the user that he is using invalid/tempered Devices. So that user can change to 'Hard Secure'/'config secure' cards. We will rephrase above line as below, "This patch will claim non-secure Aero & Sea adapter's PCI IDs & quit the device initialization (without enabling the HBA firmware) with a Error message" > > > Driver will throw an warning message when a non-secure type controller > > is detected. Purpose of this interface is to avoid interacting with > > any firmware which is not secured/signed by Broadcom. > > The request was to log a warning. Why would we want to disable support > for these devices in the driver? Actually the request is to log an error message but I was confused with your previous comment and made changes to log a warning message. As explained in description the purpose of disabling support for these devices in the driver is to avoid interacting with any firmware which is not secured/signed by Broadcom. Thanks, Sreekanth > > -- > Martin K. Petersen Oracle Linux Engineering
