Re: [PATCH 03/12] qla2xxx: Allow dev_loss_tmo setting for FC-NVMe devices

[kernel test robot <lkp@xxxxxxxxx>]

Hi Nilesh,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on dca93232b361d260413933903cd4bdbd92ebcc7f]

url:    https://github.com/0day-ci/linux/commits/Nilesh-Javali/qla2xxx-misc-features-and-bug-fixes/20200818-203851
base:    dca93232b361d260413933903cd4bdbd92ebcc7f
config: s390-randconfig-r034-20200818 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 790878f291fa5dc58a1c560cb6cc76fd1bfd1c5a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install s390 cross compiling tool for clang build
        # apt-get install binutils-s390x-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   s390x-linux-gnu-ld: drivers/scsi/qla2xxx/qla_dfs.o: in function `qla_dfs_rport_set':
>> drivers/scsi/qla2xxx/qla_dfs.c:41: undefined reference to `nvme_fc_set_remoteport_devloss'

# https://github.com/0day-ci/linux/commit/c8724abdb8c3a827186052c58054832ee10bd817
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nilesh-Javali/qla2xxx-misc-features-and-bug-fixes/20200818-203851
git checkout c8724abdb8c3a827186052c58054832ee10bd817
vim +41 drivers/scsi/qla2xxx/qla_dfs.c

    32	
    33	static int
    34	qla_dfs_rport_set(struct fc_port *fp, int attr_id, u64 val)
    35	{
    36		switch (attr_id) {
    37		case QLA_DFS_RPORT_DEVLOSS_TMO:
    38			/* Only supported for FC-NVMe devices that are registered. */
    39			if (!(fp->nvme_flag & NVME_FLAG_REGISTERED))
    40				return -EIO;
  > 41			return nvme_fc_set_remoteport_devloss(fp->nvme_remote_port,
    42							      val);
    43		default:
    44			return -EINVAL;
    45		}
    46		return 0;
    47	}
    48	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip