Re: [PATCH v2 01/11] qla2xxx: flush all sessions on zone disable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On Aug 6, 2020, at 6:10 AM, Nilesh Javali <njavali@xxxxxxxxxxx> wrote:
> 
> From: Quinn Tran <qutran@xxxxxxxxxxx>
> 
> On Zone Disable, certain switch would ignore all
> commands. This cause timeout for both switch
> scan command and abort of that command. On detection
> of this condition, all sessions will be shutdown.
> 
> Signed-off-by: Quinn Tran <qutran@xxxxxxxxxxx>
> Signed-off-by: Himanshu Madhani <hmadhani@xxxxxxxxxxx>
> Signed-off-by: Nilesh Javali <njavali@xxxxxxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_gs.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
> index 42c3ad27f1cb..c5529da1df59 100644
> --- a/drivers/scsi/qla2xxx/qla_gs.c
> +++ b/drivers/scsi/qla2xxx/qla_gs.c
> @@ -3734,6 +3734,18 @@ static void qla2x00_async_gpnft_gnnft_sp_done(srb_t *sp, int res)
> 		unsigned long flags;
> 		const char *name = sp->name;
> 
> +		if (res == QLA_OS_TIMER_EXPIRED) {
> +			/* switch is ignoring all commands.
> +			 * This might be a zone disable behavior.
> +			 * This means we hit 64s timeout.
> +			 * 22s GPNFT + 44s Abort = 64s
> +			 */
> +			ql_dbg(ql_dbg_disc, vha, 0xffff,
> +			       "%s: Switch Zone check please .\n",
> +			       name);
> +			qla2x00_mark_all_devices_lost(vha);
> +		}
> +
> 		/*
> 		 * We are in an Interrupt context, queue up this
> 		 * sp for GNNFT_DONE work. This will allow all
> -- 
> 2.19.0.rc0
> 


Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>

--
Himanshu Madhani	 Oracle Linux Engineering





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux