On Wed, 2020-08-12 at 20:47 +0800, Stanley Chu wrote: > Hi Avri, Bean, > > On Tue, 2020-08-11 at 16:18 +0200, Bean Huo wrote: > > From: Stanley Chu <stanley.chu@xxxxxxxxxxxx> > > > > If somehow no interrupt notification is raised for a completed > > request > > and its doorbell bit is cleared by host, UFS driver needs to > > cleanup > > its outstanding bit in ufshcd_abort(). Otherwise, system may behave > > abnormally by below flow: > > > > After ufshcd_abort() returns, this request will be requeued by SCSI > > layer with its outstanding bit set. Any future completed request > > will trigger ufshcd_transfer_req_compl() to handle all "completed > > outstanding bits". In this time, the "abnormal outstanding bit" > > will be detected and the "requeued request" will be chosen to > > execute > > request post-processing flow. This is wrong because this request is > > still "alive". > > > > Signed-off-by: Stanley Chu <stanley.chu@xxxxxxxxxxxx> > > Reviewed-by: Can Guo <cang@xxxxxxxxxxxxxx> > > Signed-off-by: Bean Huo <beanhuo@xxxxxxxxxx> > > Thanks Bean's patch integration. > > Like Avri's comment in https://patchwork.kernel.org/patch/11683381/ > I think you could add Acked-by tag from Avri. > Hi Avri do I need to re-send the patchset to add your Acked-by tag? or you will sign your acked-by statement and append this patch? Thanks, Bean > > > Hi Avri, > > Please correct above description if required. > Thanks for your review! : ) > > > Thanks, > > Stanley Chu >
