Hi Daniel, > -----Original Message----- > From: linux-scsi-owner@xxxxxxxxxxxxxxx <linux-scsi-owner@xxxxxxxxxxxxxxx> > On Behalf Of Daniel Wagner > Sent: Friday, August 7, 2020 1:24 PM > To: Nilesh Javali <njavali@xxxxxxxxxxx> > Cc: martin.petersen@xxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; GR-QLogic- > Storage-Upstream <GR-QLogic-Storage-Upstream@xxxxxxxxxxx> > Subject: Re: [PATCH v2 10/11] Revert "scsi: qla2xxx: Fix crash on > qla2x00_mailbox_command" > > On Thu, Aug 06, 2020 at 04:10:13AM -0700, Nilesh Javali wrote: > > FCoE adapter initialization failed for ISP8021. > > > > This reverts commit 3cb182b3fa8b7a61f05c671525494697cba39c6a. > > But wouldn't this revert not also bring back the crash from 3cb182b3fa8b > ("scsi: qla2xxx: Fix crash on qla2x00_mailbox_command"): This patch was never there in OOT driver, and we never hit an original problem. I have tested this patch myself and this have gone through test cycles as well. If an original issue is hit again, we will do an analysis and provide the fix. This revert fixes a load issues with ISP82XX. Thanks, ~Saurav > > This patch fixes a crash on qla2x00_mailbox_command caused when the > driver > is on UNLOADING state and tries to call qla2x00_poll, which triggers a > NULL pointer dereference.