Eric Moore wrote:
On Wednesday, January 31, 2007 6:52 PM, James Bottomley wrote:
what's wrong with
memcmp(lun1->scsi_lun, lun2->scsi_lun, 8)
rather than introducing a wrapper? The compiler can even optimise
memcmp for a fixed size nicely.
James
Changed to using memcmp. This replaces the prevous patch.
Signed-off-by: Eric Moore <Eric.Moore@xxxxxxx>
IMO a wrapper is better.
memcmp() is not type-safe nor type-aware, and we have already created a
type for SCSI LUNs.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
