EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On 04/08/2020 07:33, Deepak.Ukey@xxxxxxxxxxxxx wrote: > Hi Christoph, > > Yes, It is better to be implemented in libsas. Since the out of box pm80xx driver has this support, we would like to push this for the time being. We will see how this can be moved to libsas. > Other libsas users may like this feature. And libsas does already support SATA spin-up hold events - as does pm8001 - but there's not really much to that in libsas. Question: why have a module param to enable this feature? Why not solely rely on the seeprom spin-up interval, whereby a value of 0 means no staggered spin-up? - Setting spin-up interval may increase the time for device discovery. Customer who has a valid spin up interval - configured can still turn of this using module parameter. Or else, they have to reflash the seeprom. Thanks Deepak > > -----Original Message----- > From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] > Sent: Tuesday, August 4, 2020 11:33 AM > To: Deepak Ukey - I31172 <Deepak.Ukey@xxxxxxxxxxxxx> > Cc: linux-scsi@xxxxxxxxxxxxxxx; Vasanthalakshmi Tharmarajan - I30664 > <Vasanthalakshmi.Tharmarajan@xxxxxxxxxxxxx>; Viswas G - I30667 > <Viswas.G@xxxxxxxxxxxxx>; jinpu.wang@xxxxxxxxxxxxxxxx; > martin.petersen@xxxxxxxxxx; yuuzheng@xxxxxxxxxx; auradkar@xxxxxxxxxx; > vishakhavc@xxxxxxxxxx; bjashnani@xxxxxxxxxx; radha@xxxxxxxxxx; > akshatzen@xxxxxxxxxx > Subject: Re: [PATCH V6 2/2] pm80xx : Staggered spin up support. > > EXTERNAL EMAIL: Do not click links or open attachments unless you know > the content is safe > > As mentioned before - this should be a libsas or transport class policy, and not a module parameter hack in one driver. > . >
