Re: [PATCH V5 1/2] pm80xx : Support for get phy profile functionality.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Deepak,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v5.8]
[cannot apply to mkp-scsi/for-next scsi/for-next next-20200731]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Deepak-Ukey/pm80xx-Updates-for-the-driver-version-0-1-39/20200803-202113
base:    bcf876870b95592b52519ed4aafcf9d95999bc9c
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from drivers/scsi/pm8001/pm8001_sas.h:59,
                    from drivers/scsi/pm8001/pm8001_init.c:42:
>> drivers/scsi/pm8001/pm8001_ctl.h:63:15: error: duplicate member 'reserved'
      63 |  unsigned int reserved:20;
         |               ^~~~~~~~
--
   In file included from drivers/scsi/pm8001/pm8001_sas.h:59,
                    from drivers/scsi/pm8001/pm8001_hwi.c:41:
>> drivers/scsi/pm8001/pm8001_ctl.h:63:15: error: duplicate member 'reserved'
      63 |  unsigned int reserved:20;
         |               ^~~~~~~~
   drivers/scsi/pm8001/pm8001_hwi.c: In function 'mpi_set_phys_g3_with_ssc':
   drivers/scsi/pm8001/pm8001_hwi.c:413:6: warning: variable 'value' set but not used [-Wunused-but-set-variable]
     413 |  u32 value, offset, i;
         |      ^~~~~
--
   In file included from drivers/scsi/pm8001/pm8001_sas.h:59,
                    from drivers/scsi/pm8001/pm80xx_hwi.c:41:
>> drivers/scsi/pm8001/pm8001_ctl.h:63:15: error: duplicate member 'reserved'
      63 |  unsigned int reserved:20;
         |               ^~~~~~~~
   drivers/scsi/pm8001/pm80xx_hwi.c:69:6: warning: no previous prototype for 'pm80xx_pci_mem_copy' [-Wmissing-prototypes]
      69 | void pm80xx_pci_mem_copy(struct pm8001_hba_info  *pm8001_ha, u32 soffset,
         |      ^~~~~~~~~~~~~~~~~~~
   drivers/scsi/pm8001/pm80xx_hwi.c:5099:6: warning: no previous prototype for 'mpi_set_phy_profile_req' [-Wmissing-prototypes]
    5099 | void mpi_set_phy_profile_req(struct pm8001_hba_info *pm8001_ha,
         |      ^~~~~~~~~~~~~~~~~~~~~~~

vim +/reserved +63 drivers/scsi/pm8001/pm8001_ctl.h

    43	
    44	#ifdef __LITTLE_ENDIAN_BITFIELD
    45	struct phy_status {
    46		char		phy_id;
    47		unsigned int	phy_state:4;
    48		unsigned int	nlr:4;
    49		unsigned int	plr:4;
    50		unsigned int	reserved1:12;
    51		unsigned char	port_id;
    52		unsigned int	prts:4;
    53		unsigned int	reserved2:20;
    54	} __packed;
    55	#else
    56	struct phy_status {
    57		char		phy_id;
    58		unsigned int	reserved:12;
    59		unsigned int	plr:4;
    60		unsigned int	nlr:4;
    61		unsigned int	phy_state:4;
    62		unsigned char	port_id;
  > 63		unsigned int	reserved:20;
    64		unsigned int	prts:4;
    65	} __packed;
    66	#endif
    67	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux