RE: [RFC PATCH v3 2/2] ufs: change the way to complete fDeviceInit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 
> 
> > > Currently, UFS driver checks if fDeviceInit is cleared at several
> > > times, not period. This patch is to wait its completion with the
> > > period, not retrying.
> > > Many device vendors usually provides the specification on it with just
> > > period, not a combination of a number of retrying and period. So it
> > > could be proper to regard to the information coming from device
> > > vendors.
> > >
> > > I first added one device specific value regarding the information.
> > >
> > > Signed-off-by: Kiwoong Kim <kwmad.kim@xxxxxxxxxxx>
> > I still think that this patch alone is fine, and you don't need its
> > predecessor.
> > The spec requires polling, so this is a form of a more-effective-polling:
> > so be it.
> 
> If what you're mentioning 'effective' means being able to just wait for
> some long time upon completion of being cleared, it's not proper in real
> products because fDeviceInit latency usually has the biggest overhead of
> steps run during boot and some companies often try to manage its latency
> as KPI. The method like a combination of retrying and small delay make them
> harder to make it.
> Or if I understand what you meant, please let me know.
IMO, this patch is fine as it is - no need for the previous patch.
Just send it without the first patch.

Thanks,
Avri




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux