> ---------------------------------------------------------------------- > On Thu, 16 Jul 2020 14:54:43 +0300 Alexander Lobakin wrote: >> These ports ship on new boards revisions and are supported by newer >> firmware versions. >> >> Signed-off-by: Alexander Lobakin <alobakin@xxxxxxxxxxx> >> Signed-off-by: Igor Russkikh <irusskikh@xxxxxxxxxxx> > > What is the driver actually doing with them, tho? > > Looks like you translate some firmware specific field to a driver > specific field, but I can't figure out what part of the code cares > about hw_info.port_mode Hi Jakub, You are right, this info is never used/reported. Alexander is extending already existing non used field with new values from our latest hardware revisions. I thought devlink info could be a good place to output such kind of information. Thats basically a layout of *Physical* ports on device - quite useful info I think. Important thing is these ports may not be directly mapped to PCI PFs. So reading `ethtool eth*` may not explain you the real device capabilities. Do you think it makes sense adding such info to `devlink info` then? Thanks Igor
