On Tue, Jul 14, 2020 at 10:43 AM Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > > On Tue, Jul 14, 2020 at 10:35:12AM -0600, Rob Herring wrote: > > On Tue, Jul 14, 2020 at 10:15 AM Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > > > > > > On Tue, Jul 14, 2020 at 10:16:04AM -0400, Martin K. Petersen wrote: > > > > > > > > Eric, > > > > > > > > > Add the vendor-specific registers and clock for Qualcomm ICE (Inline > > > > > Crypto Engine) to the device tree node for the UFS host controller on > > > > > sdm845, so that the ufs-qcom driver will be able to use inline crypto. > > > > > > > > I would like to see an Acked-by for this patch before I merge it. > > > > > > > > > > Andy, Bjorn, or Rob: can you give Acked-by? > > > > DTS changes should go in via the QCom tree. > > > > So, the DTS patch can't be applied without the driver patches since then the > driver would misinterpret the ICE registers as the dev_ref_clk_ctrl registers. That sounds broken, but there's no context here for me to comment further. DTS changes should work with old/stable kernels. I'd suggest you get a review from Bjorn on the driver first. Rob
