Hi Avri, On Tue, 2020-07-14 at 09:29 +0000, Avri Altman wrote: > > > > > > +cleanup: > > > > > > + spin_lock_irqsave(host->host_lock, flags); > > > > > > + if (!test_bit(tag, &hba->outstanding_reqs)) { > > > Is this needed? it was already checked in line 6439. > > > > > > > I am worried about the case that interrupt comes very lately. > scsi timeout is 30sec - do you expect an interrupt to arrive after that? > Yeah, I agree that a 30s delayed interrupt sounds kind of ridiculous. This checking is just to make the cleanup flow safer. Thanks, Stanley Chu