Re: [PATCH v2 5/9] qla2xxx: Remove a superfluous cast

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Shyam Sundar <ssundar@xxxxxxxxxxx>

> On Jun 29, 2020, at 3:54 PM, Bart Van Assche <bvanassche@xxxxxxx> wrote:
> 
> Remove an unnecessary cast because it prevents the compiler to perform
> type checking.
> 
> Reviewed-by: Daniel Wagner <dwagner@xxxxxxx>
> Cc: Nilesh Javali <njavali@xxxxxxxxxxx>
> Cc: Quinn Tran <qutran@xxxxxxxxxxx>
> Cc: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
> Cc: Martin Wilck <mwilck@xxxxxxxx>
> Cc: Roman Bolshakov <r.bolshakov@xxxxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_bsg.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
> index 88c0338a2ec7..67efde1d4b8e 100644
> --- a/drivers/scsi/qla2xxx/qla_bsg.c
> +++ b/drivers/scsi/qla2xxx/qla_bsg.c
> @@ -223,8 +223,7 @@ qla24xx_proc_fcp_prio_cfg_cmd(struct bsg_job *bsg_job)
> 
> 		/* validate fcp priority data */
> 
> -		if (!qla24xx_fcp_prio_cfg_valid(vha,
> -		    (struct qla_fcp_prio_cfg *) ha->fcp_prio_cfg, 1)) {
> +		if (!qla24xx_fcp_prio_cfg_valid(vha, ha->fcp_prio_cfg, 1)) {
> 			bsg_reply->result = (DID_ERROR << 16);
> 			ret = -EINVAL;
> 			/* If buffer was invalidatic int





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux