On 29/06/2020 07:32, Hannes Reinecke wrote:
That sounds fair to me, but is an example available in this patch series
of a call to scsi_put_internal_cmd() from such a common routine? It
seems to me that all calls to scsi_put_internal_cmd() introduced in this
patch series happen from code paths that handle internal commands only?
Ah, I commented on the same thing in your latest series.
aacraid.
The function aac_fib_free() is called unconditionally for every fib, and
doesn't have the means to differentiate between 'normal' and 'internal'
commands.
Surely some fib structure flag could be set in aac_fib_alloc() for this.
Thanks
